[jpraynaud]

Content

This PR includes fixes for the observations of the M1.2 milestone audit (Cardano database artifacts on IPFS):

• Check once in the client that the IPFS RPC URL answers as a Kubo RPC API (api/v0/version), and mark the IPFS downloader unreachable with a message that names the URL when it does not
• Name both --ipfs-rpc-url and the IPFS_RPC_URL environment variable in the client --unstable refusal for an IPFS download
• Check the Kubo RPC API at the aggregator startup, and warn when it does not answer that immutable files will not be uploaded to IPFS until it does
• Create the missing parent directories of the e2e test work directory, and show its path when its creation fails

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

Issue(s)

Closes #3646

[github-actions]

Test Results

     5 files  ± 0     236 suites  ±0   52m 43s ⏱️ - 2m 56s
 4 062 tests +12   4 062 ✅ +12  0 💤 ±0  0 ❌ ±0 
12 865 runs  +43  12 865 ✅ +43  0 💤 ±0  0 ❌ ±0 

Results for commit b547fde. ± Comparison against base commit b71dced.

♻️ This comment has been updated with latest results.

[Copilot]

🟡 Changes recommended

Two critical credential-disclosure findings and one error-handling issue remain unresolved.

3 open issues

• Prevent credential leakage in startup connection error logs · New
• Redact reqwest URL credentials from HTTP error messages · New
• Propagate filesystem errors instead of panicking · New

What changed in this PR

This pull request addresses M1.2 audit findings for Cardano database artifacts on IPFS by validating Kubo RPC endpoints, improving diagnostics, and making e2e work-directory setup recursive.

Changes:

• Added cached Kubo /api/v0/version checks for client downloads and aggregator startup.
• Improved IPFS availability errors, unstable-command messaging, and startup warnings.
• Updated e2e work-directory creation to create missing parent directories and report failures.

File	Summary	Review findings
mithril-test-lab/​mithril-end-to-end/​src/​main.rs	Creates missing work-directory parents and adds coverage for nested paths.	Nit: Avoid terminating through panic!; return a contextual error and propagate it instead. (3 votes)
mithril-client/​src/​file_downloader/​ipfs.rs	Validates and caches the Kubo RPC API check before downloading IPFS files.	Critical: Raw reqwest::Error formatting can expose credentials embedded in the request URL; use a redacted or generic error. (3 votes)
mithril-client-cli/​src/​commands/​cardano_db/​download/​v2.rs	Names both IPFS configuration mechanisms in the unstable-command error.	No additional findings.
mithril-aggregator/​src/​tools/​kubo_rpc_client/​query/​mod.rs	Exposes the new Kubo version query.	No additional findings.
mithril-aggregator/​src/​tools/​kubo_rpc_client/​query/​ipfs_version.rs	Implements and tests the Kubo /api/v0/version query.	No additional findings.
mithril-aggregator/​src/​file_uploaders/​ipfs_uploader.rs	Adds backend availability checks and uploader support.	Critical: Raw startup error logging can expose credentials embedded in the Kubo endpoint URL; log a sanitized or generic availability failure. (2 votes)
mithril-aggregator/​src/​dependency_injection/​builder/​protocol/​artifacts.rs	Runs the IPFS availability check while building the immutable-file uploader.	No additional findings.

_{Review effort: Lite}

[turmelclem]

LGTM 👍

[Alenar]

LGTM