Repository navigation
Require explicit internal package source loading - #24442
MikeMcQuaid wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Disable package-path loading Library/Homebrew/env_config.rb, Library/Homebrew/utils/path.rb, Library/Homebrew/brew.sh, Library/Homebrew/test/path_loading_spec.rb, Library/Homebrew/test/utils/path_spec.rb, Library/Homebrew/test/env_config_spec.rb, docs/Homebrew-Package-Policies.md, docs/Manpage.md, manpages/brew.1 |
The path-loading setting is now a no-op, and loadable_package_path? always returns false. Tests and documentation reflect the restriction. |
Formula name lookup and source loading Library/Homebrew/formulary.rb, Library/Homebrew/formula.rb, Library/Homebrew/extend/os/linux/system_config.rb, Library/Homebrew/test/formulary_spec.rb, Library/Homebrew/test/loader_deprecations_spec.rb, Library/Homebrew/test/path_loading_spec.rb |
Formula loader selection uses names. Implicit path, URL, cache, and keg discovery is removed or deprecated. factory no longer accepts from:; keg lookup retries an unqualified name and can fall back to the keg’s .brew file. |
Cask name lookup and installed-file loading Library/Homebrew/cask/cask_loader.rb, Library/Homebrew/test/cask/*, Library/Homebrew/test/support/helper/cask.rb, Library/Homebrew/test/loader_deprecations_spec.rb, Library/Homebrew/test/path_loading_spec.rb |
Cask loader selection uses names. Installed-file loading checks the recorded metadata path. Legacy selectors and URL loading are deprecated or restricted. |
Merge Risk: 
Minimal · up to 44f93
-
The previously reported lookup and documentation issues appear corrected. No actionable merge-blocking risk is established.
Pre-merge checks: 
4
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
c49691c to
809a085
Compare
809a085 to
813d0ad
Compare
813d0ad to
be0985d
Compare
be0985d to
439bc43
Compare
- Restrict default formula and cask lookup to names, with private APIs for audited path, bottle and content loading. - Remove the internal environment override and make the old path restriction setting a no-op, including for developers. - Warn directly for unsupported references and retain deprecations for retired entry points, without restoring implicit loading. - Reject legacy input types even when a formula name is cached. - Cover rejection of implicit paths, source and installed fallbacks, and document the supported private loading APIs.
439bc43 to
44f93e4
Compare
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at High effort, with local review and testing.