Repository navigation
Conversation
Signed-off-by: marroxo <129263224+marroxo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entry at midnight and an exit at 00:10 both showed up as the same date in
trades.csv. Reloading the trades lost the exit time and any UTC offset, so they could no longer be matched to the right equity bars.Write full ISO timestamps when the bar index contains times or a timezone. Keep the date-only format for timezone-naive midnight bars.
Both new round-trip cases failed before the fix. Afterward, 188 tests passed across trade exports, validation, equity artifacts, rebalance execution, and UI services with sockets disabled.