Repository navigation
Conversation
Parse each timestamp independently so a row without fractional seconds survives alongside one with fractional seconds. Keep UTC date normalization unchanged. Signed-off-by: marroxo <129263224+marroxo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Tiingo response containing both
2024-01-02T00:00:00.000Zand2024-01-03T00:00:00Zloses the second bar. Both timestamps pass the individual date check, but pandas infers a single format when the dates are parsed together.Use mixed-format parsing for that conversion. The loader still returns UTC dates at midnight with the timezone removed.
The two-bar fixture returned one date before the fix and both dates afterward. All 33 Tiingo loader tests passed with sockets disabled. I used synthetic rows for the regression. The change is limited to date parsing and can be reverted on its own.