Repository navigation
Conversation
Read dates from the DatetimeIndex directly when the file has no mapped date column. This keeps a same-named data column from causing reset_index to fail and the loader to drop the symbol. Cover the collision with a Parquet round trip through DataLoader.fetch. Signed-off-by: marroxo <129263224+marroxo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Parquet file can have a date index named
timestampand a regular column with the same name. When no mapped date column exists,reset_index()tries to insert a secondtimestampcolumn. The loader catches the error and drops the symbol.Read dates directly from the index in that case. A mapped date column still takes precedence, and UTC normalization stays the same.
I reproduced the bug with a real Parquet file and added a test through
DataLoader.fetch. The regression failed before the fix, and all 47 local-loader tests passed afterward with sockets disabled. The change is limited to the local loader and can be reverted independently.