Repository navigation
fix: translate the Manage button on article pages - #201
Open
ernestdefoe wants to merge 1 commit into
Open
ernestdefoe wants to merge 1 commit into
ernestdefoe wants to merge 1 commit into
Conversation
Fixes #196 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196.
The article-tools dropdown on an article page had
label="Manage"hard-coded inBlogPostController.tsx, so language packs couldn't translate it. It now usesfof-blog.forum.tools.manage, which sits next to the other article tools strings inlocale/en.yml.I scanned the rest of
js/srcfor hard-coded labels, placeholders, titles and aria-labels. This was the only one. The ghostCategoryplaceholder inBlogItemis skeleton filler while loading, so I left it alone.Tested on stock Flarum 2.0.2 with an article in a blog tag, viewed as admin. The button reads "Manage". Setting the key to "Gérer" and redrawing changes the label.
check-typingsandformat-checkare clean.js/distis left for the build bot.🤖 Generated with Claude Code