Repository navigation
FreeCAD-themes: remove icon in package.xml - #21
Closed
marcuspollio wants to merge 2 commits into
Closed
marcuspollio wants to merge 2 commits into
marcuspollio wants to merge 2 commits into
Conversation
The <icon> path does not exist in the repo. Update the metadata so it does not provide a wrong path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
The
<icon>path does not exist in the repo. Update the metadata so it does not provide a wrong path.The Addon Manager already supports an icon placeholder fallback when the
<icon>is null or wrong:A new web Addon catalog could use the same metadata, so better provide no icon (see "FreeCAD documentation" in green) rather than a wrong path (see "FreeCAD-themes" in red where
altis used instead):Another approach is to provide an icon for FreeCAD-themes and indicate that as metadata. Any cool idea? 😏