Repository navigation
Fix Iris compat leaving Iris's framebuffer bound and drawing to the wrong colortex0 - #213
Open
CuddlesPrime wants to merge 1 commit into
Open
CuddlesPrime wants to merge 1 commit into
CuddlesPrime wants to merge 1 commit into
Conversation
…Iris's default framebuffer
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an Iris shader pack, Veil shaders drawn through
ShaderWrapperMixinbreak GUIs and don't show up (e.g. Create: Aeronautics' Hot Air Burner flame).Problems
@Share("drawn")doesn't carry fromapply()toclear()(they're different methods), soAdvancedFbo.unbind()never runs. In GUIs, everything drawn afterwards goes offscreen (Aeronautics ponders and inventory items).Fix
In
ShaderWrapperMixin(NeoForge and Fabric):applyand restore them inclear.shouldOverrideShaders()is true and it isn't the shadow pass, matching Iris's own handling of unknown shaders.IrisRenderingPipeline.bindDefault(), which picks the correct colortex0 copy.IrisRenderingPipelineMixinandIrisRenderingPipelineExtensionare no longer used and are removed.