Repository navigation
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 81167dc8..5b30fc8f 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -11277,7 +11277,7 @@ ${reportName}`,
exportInProgress: '导出进行中',
conciergeWillSend: 'Concierge 将很快把文件发送给你。',
currentView: '当前视图',
- currentViewGroupsOnly: '当前视图(仅分组)',
+ currentViewGroupsOnly: '当前视图(仅限群组)',
},
exportDownload: {
preparingTitle: 'Preparing download...',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Add Current view (groups only) alongside the existing export option for grouped searches, including Bank reconciliation. Preserve the configured group columns and selection/filter scope while requesting summary-only output in both immediate and queued exports. Deploy Auth, then Web-Expensify, before releasing this option.
Fixed Issues
$ #104047
PROPOSAL: N/A — internal implementation following the issue's agreed scope.
Tests
groupsOnly=true,isBasicExport=false, the withdrawal grouping, and the configured group columns.Verified with Playwright in desktop Chrome. Captured form/query values:
{ "groupsOnly": "true", "isGroupExport": "true", "groupBy": "withdrawal-id", "groupColumns": [ "groupWithdrawn", "groupWithdrawalStatus", "groupBankAccount", "groupWithdrawalID", "groupExpenses", "groupTotal" ], "searchKey": "reconciliation" }The request was deliberately aborted after capture because the shared Auth service was not restarted. Separately, the rebuilt backend and production PHP CSV responder were exercised on isolated instances. Their actual emitted CSV was:
That file contains one header and two summaries, without expense rows. The queued CSV writer produced identical bytes; the existing export retained expense sections. Backend validation passed: 26 Auth tests and 3 targeted PHP tests / 28 assertions.
Added automated regression coverage. Local App validation:
react-native-reanimated/jest/resolver. Targeted files:SearchActionsTest.ts,useSearchBulkActionsExportTest.ts, anduseSearchBulkActionsTest.ts.npm run lint-changed: its fetch fails on the Mobile-Expensify submodule authentication.Exec format error.ts-nodeis not installed. Shared dependencies were not reinstalled.A complete browser-to-backend download, native/mobile QA, and the blocked App checks remain outstanding.
Offline tests
Not executed locally. Before marking this PR ready:
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not tested.
Android: mWeb Chrome
Not tested.
iOS: Native
Not tested.
iOS: mWeb Safari
Not tested.
MacOS: Chrome / Safari
Desktop Chrome menu and outgoing request verified with Playwright; captured request evidence is in Tests above. Safari was not tested. No screenshot is attached.