Remove unsafe assertions from attachment and expense confirmation flows

[KJ21-ENG]

Explanation of Change

Replace assertions with checked file, nullable validation, and confirmation route boundaries, and correct the Node promise-hook declarations used by tests. Unsupported inputs now have explicit TypeError messages and stacks; replacement requires a File, scan validates the full Blob batch before callback writes (earlier extraction/normalization may still occur), confirmation ignores non-Blob receipt metadata, and malformed FileReader results use the existing fallback.

Changed files:

• patches/@types/node/@types+node+20.19.9+001+promise-hooks-init-contract.patch
• patches/@types/node/details.md
• src/hooks/useFilesValidation.tsx
• src/libs/fileDownload/FileUtils.ts
• src/libs/validateAttachmentFile.ts
• src/pages/inbox/report/ReportActionCompose/useAttachmentPicker.ts
• src/pages/inbox/report/ReportActionCompose/useReceiptDrop.ts
• src/pages/iou/request/step/IOURequestStepConfirmation.tsx
• tests/ui/components/IOURequestStepConfirmationBoundaryTest.tsx
• tests/unit/FileUtilsTest.ts
• tests/unit/components/MoneyRequestConfirmationList/ConfirmationFooterContent.test.tsx
• tests/unit/hooks/useAttachmentPicker.test.ts
• tests/unit/hooks/useConciergeAttachmentPicker.test.tsx
• tests/unit/hooks/useFilesValidation.test.ts
• tests/unit/hooks/useReceiptDrop.test.ts

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

Focused repository lint, TypeScript, formatting and spelling checks passed;

Offline tests

With the PR build and relevant chats already loaded, disconnect before case 1: select and send ordinary attachments, expect readable local previews and a pending message, then reconnect and verify each accepted file sends once with its original content and order.

QA Steps

• 1. Chat attachments.

  • In a writable chat, select distinct images and a labelled PDF, including a filename needing cleanup.
  • Inspect the previews, cancel, reselect, send and open the sent content.
  • Expect correct files, usable previews, no send on Cancel, and readable sent attachments.

• 2. Receipt batch drop.

  • Drop two distinct small images onto Scan receipts in a self-chat.
  • Inspect both confirmations, edit the required fields, confirm the batch with the primary create button and inspect the resulting receipts.
  • Expect one correct expense/receipt per image with the corresponding content.

• 3. Receipt replacement drop.

  • Drop a distinct small image onto Replace receipt for an editable expense, then reopen it.
  • Expect the intended receipt to be replaced and the replacement to persist.

• 4. Manual form and Back.

  • In global Create expense > Manual, enter and edit Amount and Merchant directly in the form.
  • Open the destination selector, choose the intended destination and return.
  • Expect the values and destination to remain visible, usable keyboard controls, one header and a Create expense button.
  • Stop before activating Create expense; use the header Back control and expect the creation panel to close without submitting.

• 5. Scan confirmation and Back.

  • Use global Create expense > Scan and select a receipt.
  • At confirmation, edit Amount and Merchant and check that the receipt and edited values remain visible.
  • Use App Back and expect the preceding screen for that flow.
  • If Scan opens participant selection before confirmation, choose a participant, continue, then use App Back; expect participant selection and the same receipt and edited values when continuing again.
  • Stop before creating the expense.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Recordings (2)

01-mixed-attachments-desktop.mp4

02-manual-scan-back-desktop.mp4

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useFilesValidation.tsx	95.00% <100.00%> (+0.09%)	⬆️
src/libs/fileDownload/FileUtils.ts	55.30% <100.00%> (+8.04%)	⬆️
src/libs/validateAttachmentFile.ts	98.00% <100.00%> (+0.08%)	⬆️
.../report/ReportActionCompose/useAttachmentPicker.ts	72.09% <100.00%> (+37.94%)	⬆️
...inbox/report/ReportActionCompose/useReceiptDrop.ts	98.14% <100.00%> (+41.89%)	⬆️
...questStepConfirmation/useParticipantPickerState.ts	82.92% <ø> (ø)
.../request/step/IOURequestStepConfirmation/index.tsx	84.21% <84.61%> (+7.97%)	⬆️
... and 27 files with indirect coverage changes