Remove unsafe assertions from participant, spreadsheet, KYC and menu components

[KJ21-ENG]

Explanation of Change

Remove unsafe assertions by matching participant, spreadsheet, KYC, tooltip and menu types to their actual inputs. Unsupported spreadsheet inputs and web location targets now stop before unsafe use, unsupported layout contributions are ignored, and a click blurs only a callable target.

Changed files:

• src/components/ImportSpreadsheet.tsx
• src/components/KYCWall/BaseKYCWall.tsx
• src/components/MenuItem/MenuItem.tsx
• src/components/OptionRow.tsx
• src/hooks/useSearchSelector/base.ts
• src/hooks/useSearchSelector/index.native.ts
• src/hooks/useSearchSelector/index.ts
• src/libs/OptionsListUtils/index.ts
• src/libs/ReportUtils.ts
• src/libs/actions/ImportSpreadsheet.ts
• src/libs/getClickedTargetLocation/index.ts
• src/libs/getClickedTargetLocation/types.ts
• src/pages/iou/request/ParticipantSearchResults.tsx
• src/styles/utils/index.ts
• tests/ui/components/ImportSpreadsheetTest.tsx
• tests/ui/components/KYCWallTest.tsx
• tests/ui/components/MenuItemTest.tsx
• tests/ui/components/OptionRowTest.tsx
• tests/ui/components/ParticipantSearchResultsTest.tsx
• tests/unit/OptionsListUtilsTest.tsx
• tests/unit/getClickedTargetLocationTest.ts
• tests/unit/useSearchSelectorTest.tsx

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

Focused TypeScript, lint, format, spelling and Jest checks passed on the changed paths.

QA Steps

• 1. Participant selection.

  • Start an expense, choose an existing contact and inspect the selected recipient.
  • Expect that contact exactly once, without retaining a previous recipient.
  • Leave without submitting.

• 2. Spreadsheet import.

  • Pick a CSV containing mixed text/date values and inspect the mapping, then try an empty CSV.
  • Expect literal values to be preserved and the empty file to be rejected without opening mapping.
  • Also drag a CSV onto the desktop import area: expect a correctly positioned drop prompt and a single mapping flow.

• 3. Payment popup positioning.

  • As a payer with no personal bank account or valid debit method, open a received unpaid personal IOU in a supported currency.
  • In the report's payment actions, choose Pay with personal account.
  • Expect the menu offering Personal bank account and Business bank account beside its trigger.
  • Resize the desktop window, then dismiss the menu.
  • Expect it to remain correctly anchored and usable.
  • Do not select a bank option or start setup/payment.

• 4. Profile menu navigation.

  • Open Profile > Personal details > Legal name using the pointer, return, and repeat using keyboard navigation on desktop.
  • Check the title/description in a narrow layout too.
  • Expect readable text, working Back navigation and no stuck selection/focus state.

PR Author Checklist

No app copy, assets or CSS declarations were added. Manual execution remains pending.

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Recordings (5)

01-participant-desktop.mp4

02-csv-picker-desktop.mp4

03-empty-csv-desktop.mp4

04-profile-header-desktop.mp4

05-profile-header-narrow.mp4

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ImportSpreadsheet.tsx	81.81% <100.00%> (+81.81%)	⬆️
src/components/KYCWall/BaseKYCWall.tsx	61.87% <100.00%> (+33.14%)	⬆️
src/components/MenuItem/MenuItem.tsx	91.72% <100.00%> (+0.05%)	⬆️
src/components/OptionRow.tsx	94.73% <100.00%> (+93.68%)	⬆️
src/hooks/useSearchSelector/base.ts	88.61% <100.00%> (+1.62%)	⬆️
src/hooks/useSearchSelector/index.native.ts	100.00% <ø> (ø)
src/hooks/useSearchSelector/index.ts	0.00% <ø> (ø)
src/libs/OptionsListUtils/index.ts	92.48% <100.00%> (+0.68%)	⬆️
src/libs/ReportUtils.ts	88.56% <ø> (+0.03%)	⬆️
src/libs/actions/ImportSpreadsheet.ts	76.71% <ø> (ø)
... and 3 more
... and 36 files with indirect coverage changes