Repository navigation
[HOLD Auth#25045] Add support for MERGEDEXPENSEDELETED report action - #102786
youssef-lr wants to merge 1 commit into
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Heads up: moved into #102438, this PR will probably show up as merged without review once the other PR is merged. |
Explanation of Change
MERGEDEXPENSEDELETEDreport action, which the backend sends when an admin merges a submitter's expenses and moves one to Deleted.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/678389
PROPOSAL:
Tests
Offline tests
N/A, the action is created by the backend.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests, once https://github.com/Expensify/Auth/pull/25045 is deployed.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari