Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
All contributors have signed the CLA ✍️ ✅ |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
20f4f28 to
7eca905
Compare
|
@shawnborton @QichenZhu One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Let us know when this is ready for @Expensify/design review. |
…ased callback names.
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
This doesn't feel super great when you enable a bunch of fields that don't have values. I wonder if we should have some kind of default "None" value added to these rows that don't actually have values? cc @Expensify/design for thoughts, but the legibility of this feels quite off:
cc @flaviadefaria @trjExpensify for a review too please! |
|
The feature itself seems to work really well though! |
I agree! I think we should add |
Yeah I agree. They look especially weird since they're empty and can't be edited. I do think the new input style would help with this, but barring that, I'm not against putting in some kind of none or blank placeholder value here. |
|
Hot take. Should we just park this PR? I see we've merged a PR to add the report level setting to switch to a table view as a preference for one-expense reports. I could see us just starting there. |
|
I think some folks felt strongly that if you can customize fields/columns at the report level, you should be able to do it at the expense level as well. Perhaps you can bring that discussion to Slack, Tom? |
|
Cool. I guess first of all, @flaviadefaria do you think this is still beneficial and necessary in light of the other PR now? |
|
I see where you’re coming from, but I think there’s room for debate. One could argue that users shouldn’t have to switch views just to see all the expense columns or fields. Personally, I’m fine with parking this for now, but that’s just my perspective. I’m not sure whether we should align with the rest before making that call. |
|
Fwiw, I think this view is much easier to parse than the single expense, report view, where you'd need to scroll horizontally |
|
Cool, if yous are still for it we can keep it moving. On the question above, I don't think we should put a placeholder value in the fields, as we don't in the table view for "blank" columns. I do think the page will look nicer with the new in-line inputs, so hopefully we can get to the "post creation" expense forms soon. |
@JS00001, yeah, it's also easier to use on mobile. Do we intend to support mobile? It already mostly works, except for drag-to-reorder. ios.mov |
|
That's a good question. I would say we would support mobile here, because we dont have the same horizontal constraint problem that we have for other custom columns on mobile Thoughts @Expensify/design ? |
|
Yeah I agree that we'd support mobile too.
I'm cool with this as well—down to just leave these as they are |
|
Yup, all of that works for me. Agree that we'd do this on mobile, too. |
|
@brunovjk, is it possible to support reordering on mobile? drag-to-reorder.mov |
Thanks for the review, I'll check ASAP. |
|
Could you take a look now, @QichenZhu? Thanks. |
|
@brunovjk, the latest commit is much bigger than I expected. Could you summarize what changed and why the fix needs to be this large? Thanks! |
|
@QichenZhu. I included a few related fixes and cleanups while working on mobile reordering, which made the commit larger than expected. |
|
@brunovjk, thanks for the explanation. No need to split them. |
|
Im fixing the warning now |
|
All yours @QichenZhu |

Explanation of Change
This PR adds support for displaying the report's configured custom columns as read-only fields in single-expense report and expense views.
It also adds the Customize fields option to allow configuring which fields are displayed, reusing the same column preferences used by the report view.
Fixed Issues
$ #101300
PROPOSAL: N/A
Tests
Test Steps
Offline tests
Same as Test Steps
QA Steps
Same as Test Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-06.at.10.33.27.mov
Android: mWeb Chrome
iOS: Native
102457_ios_native.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
102457_web_chrome.mov