Repository navigation
Add ask Concierge screen - #100552
Add ask Concierge screen#100552rushatgabhane wants to merge 110 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@mkhutornyi next PR that you can start reviewing |
|
fixed this. now the button will show hide chat history after sending multiple attachments |
This is not fixed yet Screen.Recording.2026-10-16.at.12.48.05.PM.mov |
|
Please check Melvin, Codex comments and below comments and address valid bugs. 1. An open Concierge task is buried behind the welcome screenApp/src/hooks/useConciergeAskState.ts Line 87 in 7b28190 Preconditions: an open task in the Concierge chat assigned to you, its message already read, and you have messaged Concierge at least once before.
Expected: the open task is on screen, as on
2. "Ask Concierge" from Search posts into your previous thread
Expected: a new Concierge thread for the new question.
3. The history toggle reads "View chat history" while messages are on screenApp/src/pages/inbox/report/ReportActionCompose/useComposerSubmit.ts Lines 108 to 110 in 7b28190 Preconditions: Concierge chat with prior history, so View chat history is present.
Expected: the welcome screen, the way the chat looks after sending a question. A multi-attachment send is the only thing that posts to the DM without opening a child report, so it already counts as session activity and dismisses the welcome on its own. |
not a bug. after you send a messge once, we start showing the welcome screen |
fixed |
|
@MelvinBot fix eslint |
Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
|
I fixed the ESLint errors and pushed the fix in 804aff59.
ESLint and typecheck pass locally on the changed files, and all 80 |
Explanation of Change
Builds the Ask Concierge screen from the Figma design in the main Concierge DM: a centered welcome empty state, a chat history toggle that expands and collapses the earlier conversation, and a
Your personal AI assistantsubtitle plus aNew chatbutton in question threads. It also removes theconciergeRespondInThreadbeta, so Concierge answers every question from the main DM in its own thread, including a message with several attachments. This needs https://github.com/Expensify/Web-Expensify/pull/57207 deployed first.Fixed Issues
For #94503
PROPOSAL:
Tests
Conciergewith the subtitleYour personal AI assistant, and the composer placeholder isHow much did I spend last month?.Ask me anything!, and the supporting copy. On a wide screen, verify the welcome and the composer are centered together. On a small screen (mobile), verify the welcome is centered above a composer docked at the bottom.View chat history, verify the earlier conversation appears withAsk a new questionabove the composer, then pressHide chat historyand verify it collapses again.New chatbutton that returns you to the Concierge chat in its welcome state.What are these?and send. Verify one message shows both images, a thread opens off it, Concierge replies once in the thread.Offline tests
Same as tests. The welcome state and the history toggle both read data already in Onyx, so they render offline; only expanding history beyond the cached page needs a connection.
QA Steps
View chat history/Hide chat historytoggle works.New chatand returns you to the Concierge chat.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-02.at.15.16.02.mov
Old stuff
Screen.Recording.2026-09-14.at.06.10.11.mov