Skip to content

fix(release): unblock 0.2.0 publication with valid merged-PR CI provenance - #5

Merged
Drako01 merged 1 commit into
mainfrom
fix/release-provenance-merged-pr
Nov 10, 2026
Merged

Drako01 merged 1 commit into
mainfrom
fix/release-provenance-merged-pr

Conversation

@Drako01

@Drako01 Drako01 commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Root cause confirmed

The 0.2.0 publish run #42872348027 failed in Reuse verified PR VSIX because GitHub returned workflow_run.pull_requests: [] after merging PR #4. Our resolver incorrectly required this volatile metadata to contain PR #4. It rejected the valid successful pre-merge CI run #42871117473.

Direct evidence:

Fix

  • Accept pull_requests: [] for a CI run only when the merged PR has already been independently resolved and the run matches the exact approved PR head SHA, repository, CI workflow, event, successful status and pre-merge date.
  • Continue to reject mismatched nonempty associations, missing association metadata, foreign repos, wrong SHA, failed/cancelled/late/non-PR workflows.
  • Verify the downloaded VSIX manifest (PR ID, run ID, SHA, Git tree, version, SHA-256), unchanged.
  • Add regression test reproducing GitHub's empty association behavior and document recovery.

Release outcome

Keep v0.2.0: it has not published, so bumping to 0.2.1 is unnecessary. Once this PR passes all required PR checks and the owner merges it, the existing publish.yml on main can publish the exact VSIX validated by this new PR, without rerunning typecheck/lint/unit/mutation/E2E after the merge. This PR does not publish anything by itself.

Acceptance

  • Verify (ubuntu-latest) success
  • Verify (windows-latest) success
  • Verify (macos-latest) success
  • Package installable preview VSIX success; artifact available
  • Owner merges after all checks green; watch publish jobs, OIDC/storefronts, and GitHub Release

No bypass of provenance, no post-merge tests, no direct push to main.

…ociations

GitHub Actions can return workflow_run.pull_requests=[] once a pull request has merged. Preserve strict release provenance without falsely rejecting successful exact-head CI: require merged PR identity, the expected SHA and repository, the CI workflow and event, pre-merge completion, successful status, matching Git tree, artifact manifest, version and VSIX SHA-256. Reject unrelated nonempty PR associations.

Add regression coverage reproducing PR #4 -> CI #42871117473 and document the single-validation policy. Keep v0.2.0 because no 0.2.0 release was published.
@Drako01
Drako01 merged commit 122c1dc into main Nov 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant