Repository navigation
fix(release): unblock 0.2.0 publication with valid merged-PR CI provenance - #5
Merged
Merged
Conversation
…ociations GitHub Actions can return workflow_run.pull_requests=[] once a pull request has merged. Preserve strict release provenance without falsely rejecting successful exact-head CI: require merged PR identity, the expected SHA and repository, the CI workflow and event, pre-merge completion, successful status, matching Git tree, artifact manifest, version and VSIX SHA-256. Reject unrelated nonempty PR associations. Add regression coverage reproducing PR #4 -> CI #42871117473 and document the single-validation policy. Keep v0.2.0 because no 0.2.0 release was published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause confirmed
The 0.2.0 publish run #42872348027 failed in
Reuse verified PR VSIXbecause GitHub returnedworkflow_run.pull_requests: []after merging PR #4. Our resolver incorrectly required this volatile metadata to contain PR #4. It rejected the valid successful pre-merge CI run #42871117473.Direct evidence:
0e04ec1; successful pre-merge CI head:0e04ec1.8bdba0etree SHA15260955ec0529b1c365eefdf9c46f75a179dbe1equals the PR-tested source tree.Fix
pull_requests: []for a CI run only when the merged PR has already been independently resolved and the run matches the exact approved PR head SHA, repository, CI workflow, event, successful status and pre-merge date.Release outcome
Keep v0.2.0: it has not published, so bumping to 0.2.1 is unnecessary. Once this PR passes all required PR checks and the owner merges it, the existing
publish.ymlonmaincan publish the exact VSIX validated by this new PR, without rerunning typecheck/lint/unit/mutation/E2E after the merge. This PR does not publish anything by itself.Acceptance
Verify (ubuntu-latest)successVerify (windows-latest)successVerify (macos-latest)successPackage installable preview VSIXsuccess; artifact availableNo bypass of provenance, no post-merge tests, no direct push to main.