Repository navigation
Finish strict Calcit migration and fix Run button runtime - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration, runtime fixes, dependency updates, and CI coverage are internally consistent with no unresolved issues found.
Review effort: Balanced
Findings: None
What changed in this PR
Completes the strict Calcit migration, fixes runtime dispatch behavior, strengthens regression coverage, and updates the frontend toolchain.
Changes:
- Migrates runtime state operations and CDN detection to typed APIs.
- Adds regression tests and stricter CI validation.
- Updates Vite and removes unused Calcit dependencies.
| File | Description |
|---|---|
.github/workflows/upload.yaml |
Adds strict checks, regression tests, and serialized uploads. |
.gitignore |
Ignores retired Calcit snapshots. |
README.md |
Documents requirements and verification steps. |
calcit.cirru |
Implements typed operations, configuration, and store construction. |
deps.cirru |
Removes unused dependencies and aligns js-ffi. |
package.json |
Updates Vite to 8.3.1. |
scripts/former-regression.test.mjs |
Adds runtime regression coverage. |
yarn.lock |
Locks the updated Vite dependency graph. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up merged #13. Fix two remaining double-argument live-button dispatches to nominal Op :states, including delayed reset, and remove a stray AST invocation wrapper that called a Bool as a function during render. Move legacy CDN host detection into a typed lexical FFI adapter using Option-unwrapped get-env and a proper final cond branch; preserve Node/browser behavior and reduce type debt. Migrate legacy Struct construction to callable Store. Remove only unused Lilac/Memof/Markdown declarations, align js-ffi to compatible Respo/UI graph, and update Vite to 8.3.1. Verified strict 5-module Caps/toolchain, immutable Yarn 4.18, Calcit/procs 0.27 strict-v1, 17/17 app public definitions, existing unit test and 6 runtime regressions (button/timer, Run conversion, textareas, missing value, hydration, CDN env). Original quality budget unchanged and passes; typeNone improved 2 to 0, typeNotFull 5 to 3; no unsafe coercions. Add canonical snapshot absence guards, shared PR prefix serialization. Original frontend-only COS prefixes and rsync source/destination unchanged. Latest remote upload validation still required before production/main claim.
Latest simplification: remove the extra local HTML/CDN assertion; COS upload/public verification uses only the action's built-in verify. Existing Calcit and functional checks remain. Cleanup CI passed: https://github.com/Cirru/data-former/actions/runs/36809301370. Built-in Action publicly verified three files; no merge performed.