Repository navigation
Draw the geolocate error slash deliberately - #42
Merged
Merged
Conversation
Denied permission or a failed watch put the stock control into an error state whose sprite has the red slash baked in — through our mask glyph it leaked as a barely-visible red stroke, which read as a rendering bug rather than an indicator. The sprite is gone; the slash is drawn on the button's own layer in the theme's error color, at full strength over the dimmed glyph, in both themes. A plain disabled control (geolocation unsupported) stays dim without the slash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Denied permission or a failed watch put the stock geolocate control into an error state whose sprite has the red slash baked in; through our mask glyph it leaked as a barely-visible red stroke. The stock sprite is suppressed for the error states, and the slash is drawn explicitly on the button's own layer — full-strength
--error-textacross the dimmed glyph, both themes. A plain disabled control (geolocation unsupported) stays dim, without the slash.Verified live in light and dark themes by applying the error class: slash clearly visible in both; disabled-without-error shows no slash.
next buildgreen.