Skip to content

Draw the geolocate error slash deliberately - #42

Merged
egorikftp merged 1 commit into
mainfrom
fix/geolocate-error-slash
Nov 15, 2026
Merged

egorikftp merged 1 commit into
mainfrom
fix/geolocate-error-slash

Conversation

@egorikftp

Copy link
Copy Markdown
Contributor

Closes #41

Denied permission or a failed watch put the stock geolocate control into an error state whose sprite has the red slash baked in; through our mask glyph it leaked as a barely-visible red stroke. The stock sprite is suppressed for the error states, and the slash is drawn explicitly on the button's own layer — full-strength --error-text across the dimmed glyph, both themes. A plain disabled control (geolocation unsupported) stays dim, without the slash.

Verified live in light and dark themes by applying the error class: slash clearly visible in both; disabled-without-error shows no slash. next build green.

Denied permission or a failed watch put the stock control into an
error state whose sprite has the red slash baked in — through our
mask glyph it leaked as a barely-visible red stroke, which read as a
rendering bug rather than an indicator. The sprite is gone; the slash
is drawn on the button's own layer in the theme's error color, at full
strength over the dimmed glyph, in both themes. A plain disabled
control (geolocation unsupported) stays dim without the slash.
@egorikftp
egorikftp merged commit 9cc425d into main Nov 15, 2026
1 check passed
@egorikftp
egorikftp deleted the fix/geolocate-error-slash branch November 15, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geolocate error state is barely visible

1 participant