Skip to content

docs(skills): fixes from a full setup, test and CI run - #27

Merged
kevinccbsg merged 6 commits into
mainfrom
fix/skill-findings-from-test-run
Oct 15, 2026
Merged

kevinccbsg merged 6 commits into
mainfrom
fix/skill-findings-from-test-run

Conversation

@kevinccbsg

@kevinccbsg kevinccbsg commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Fixes found by running /twd:setup, /twd:twd and /twd:ci-setup end to end on a React + json-server app (courses/test-skill).

Closes #21, closes #22, closes #23, closes #24, closes #25, closes #26

Bumps the plugin to 1.3.5 so installed copies pick up the changes.

- ci-setup: derive the contract baseUrl from the real mock URLs and check that mocks were validated (#21)
- setup: scaffold imports only twd (#22)
- setup: run the type-check command once during verification (#23)
- setup: detect MockedComponent and offer component mocking for third-party components (#24)
- ci-setup: offer to exclude TWD tests from an existing istanbul config (#25)
- twd: findBy* for every query, getBy* only inside twd.waitFor (#26)
@kevinccbsg
kevinccbsg marked this pull request as ready for review October 15, 2026 18:18
Reuse the variable while the element stays mounted; query again with the expected state when the change is async or the element is replaced.
Component and module mocking is rare; setup reads references/third-party.md only when the project has third-party code to mock.
@kevinccbsg
kevinccbsg merged commit da39213 into main Oct 15, 2026
1 check passed
@kevinccbsg
kevinccbsg deleted the fix/skill-findings-from-test-run branch October 15, 2026 18:50
kevinccbsg added a commit to BRIKEV/twd that referenced this pull request Oct 15, 2026
The docs presented getBy and twd.get as equal alternatives to findBy, which
leads to flaky tests: TWD runs against a real app that renders
asynchronously, so a bare getBy after visit or a click throws in CI.

Document one priority order, matching the twd-ai skill (BRIKEV/twd-ai#27):
findBy for every lookup, queryBy only for absence, getBy only inside
twd.waitFor, twd.get as the last resort. Convert the examples across the
docs to follow it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment