Repository navigation
docs(skills): load less text per run, type-check before the first run - #18
Merged
Merged
Conversation
- split test-writing.md into a core reference and test-api.md, read on demand; the twd skill's write task loads 43% less text - twd type-checks the tests it writes before the first browser run; setup records the project's type-check command in twd-patterns.md - setup moves the non-Vite entry-file blocks and the server-state cache material into references read only when detected - ci-setup reads the custom workflow, contracts and recording references only when that option is chosen; ci.md moves under ci-setup and its duplicates of the skill go away - contract strict defaults to true, as twd-cli does
- validate.yml runs `claude plugin validate --strict` on the manifests and skills, and checks that every references/*.md a skill names exists - evals/ holds four `claude plugin eval` cases for twd (flow and component tests), setup on Angular and ci-setup with recording; each scaffolds a project and grades the files the skill writes
…ular Angular is a residual case; the eval should cover what most projects run. The new case also exercises the server-state cache reference this PR moved out of the setup skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text-only pass on the three skills used most (
twd,setup,ci-setup): load only the material a run needs, and catch wrong API calls with the type checker instead of a browser run.Load less per run
twd, writing a testci-setup, GitHub Action pathsetup, Vite projecttwdtest-writing.mdis now the core (32 KB → 8 KB).waitFor, Sinon, and the uncommon interactions and assertions move totest-api.md, read on demand.setup: the non-Vite entry-file blocks and the server-state cache table and scaffolds move tosetup/references/, read only when detection finds them.ci-setupci.mdis replaced byci-setup/references/{custom-workflow,contracts,recording}.md, each read only when that option is chosen.skills/twd/references/ci.mdpath only resolved from the plugin root.Type-check before the first run
twdruns the project's type checker on the tests it wrote before the first browser run.tsc --noEmit -p tsconfig.app.json, which catchesbody:forresponse:, positionalmockRequestarguments,headers:and Jest matchers.rule.request.body(typedany) and a missingawaitare not caught, so those stay as written rules.setuprecords the command asType-check commandintwd-patterns.md: atypecheckscript if present,vue-tscfor Vue, otherwisetsc -p tsconfig.app.json.Fix
strictdefaults totrue(twd-clicontracts.js); the old table saidfalse.Plugin version 1.3.2 → 1.3.3.
Validation and evals
.github/workflows/validate.ymlclaude plugin validate --stricton the manifests and skills, with the CLI pinned to 2.1.295 and no credentials.references/*.mda skill names exists.validatedoesn't look at skill text, and this PR moved several references.evals/: fourclaude plugin evalcases (twdflow test,twdcomponent test,setupon Vite + React + TanStack Query,ci-setupwith recording). Each scaffolds a small project and grades the files the skill writes. Seeevals/README.md.isDevMode(), no define), so this kind of case does catch regressions. It was swapped for the more common Vite + React + TanStack Query setup..claude/, so the setup case grades the attemptedtwd-patterns.mdwrite from the trace.