Repository navigation
fix(examples): preserve dataframe envelopes and empty schema - #165
TimeToBuildBob wants to merge 2 commits into
Conversation
Git-Session-Id: 6132cfcc-d334-4685-b9de-d711c87f332d
🤖 AI code reviewSafe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Reviewed Maintainer commands
|
[Low impact] The PR appears safe to merge. SummaryPreserves event timestamps and durations when payload fields use the same names.
Acknowledged limitation: TimeToBuildBob explicitly states that pandas’ existing behavior for literal dotted keys and matching nested paths is unchanged. Reviews (1) · Last reviewed commit: "fix(examples): preserve dataframe envelo..." · Reviewed by Greptile |
Git-Session-Id: 67650616-bd07-5232-aaf4-a2690af49abc
|
Fixed the CI setup failure in Local verification: 128 offline tests pass (122 repository tests plus the six dataframe regressions); mypy passes for all 31 source files, workflow YAML/matrix assertions and |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Summary
Reproduction
Fetched master c88cf12: empty queries raise KeyError(timestamp), and payload timestamp/duration overwrite envelope values. New tests first reproduced four failures with two ordinary controls passing.
Verification
No production history, live server, remote export or canonical-query behavior was exercised. Existing pandas literal-dotted/nested payload-path alias behavior is explicitly unchanged.