Repository navigation
fix(dataset): update batch_size in sampling_parameters_json during project top-ups - #1273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the automated dataset pipeline where project top-ups would result in stale metadata being displayed in the project settings UI.
Bug Fixes
create_projects_for_dataset_categorylogic insidedataset/tasks.py. Previously, when a pipeline dynamically topped up an existing project by pulling in new tasks, thesampling_parameters_json.batch_sizefield remained as a static snapshot taken during the original project creation. This caused the "Batch Size" field in the UI settings to go out-of-sync with the actual task count. The batch size is now accurately updated and kept in sync by adding the length of newly pulled items to the existing value.Testing Instructions