Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v1.51.3 offline Codex smoke reached the read-only
hooks/listpreflight but did not confirmtrustStatus: trustedfor the two TEST Stop handlers. This can be a TUI operation/persistence issue, not a product defect.Scope
/hookskey bindings: Enter opens Stop, t trusts the selected handler, and Enter/Space on an already-trusted handler toggles enablement.config/batchWritepersists asynchronously. Explain how to inspect privateconfig.tomland the existing read-onlyhooks-list.jsonreceipt without bypassing or writing trust manually.Only the smoke README changes. No candidate/runtime/workflow bytes change, no turn was started, and this PR does not qualify E2E or authorize release publication.
Verification
openai/codexatrust-v0.162.0, especiallyhooks_browser_view.rs,hooks_rpc.rs, andapp/background_requests.rs.9270bc0893be3d0abb049f4525f20962df113343observer:hookListsaveshooks-list.jsonbefore the trust assertions;turn-started.jsonis created only after both checks pass.