Skip to content

docs(codex): clarify isolated Stop hook trust and persistence check - #641

Draft
777genius wants to merge 1 commit into
mainfrom
docs/codex-smoke-trust-review-20261109
Draft

777genius wants to merge 1 commit into
mainfrom
docs/codex-smoke-trust-review-20261109

Conversation

@777genius

Copy link
Copy Markdown
Owner

Why

The v1.51.3 offline Codex smoke reached the read-only hooks/list preflight but did not confirm trustStatus: trusted for the two TEST Stop handlers. This can be a TUI operation/persistence issue, not a product defect.

Scope

  • Document the verified Codex CLI 0.162.0 /hooks key bindings: Enter opens Stop, t trusts the selected handler, and Enter/Space on an already-trusted handler toggles enablement.
  • Warn that t on the events page trusts all, which is not allowed in this scoped TEST.
  • Clarify that the TUI marks trust optimistically while config/batchWrite persists asynchronously. Explain how to inspect private config.toml and the existing read-only hooks-list.json receipt without bypassing or writing trust manually.
  • Preserve old TEST evidence and require a new TEST root for another attempt.

Only the smoke README changes. No candidate/runtime/workflow bytes change, no turn was started, and this PR does not qualify E2E or authorize release publication.

Verification

  • Inspected source of openai/codex at rust-v0.162.0, especially hooks_browser_view.rs, hooks_rpc.rs, and app/background_requests.rs.
  • Cross-checked the behavior against frozen 9270bc0893be3d0abb049f4525f20962df113343 observer: hookList saves hooks-list.json before the trust assertions; turn-started.json is created only after both checks pass.
  • Actual native macOS ARM64 TEST trust/turn/Stop/webhook E2E is still pending, and prior evidence is untouched.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant