Repository navigation
Conversation
…on viewer History listed every version, but selecting one from before the document went live asked for a Y.Doc that was never captured, so it showed 'not found'. The versions list now says which versions are bundled checkpoints; selecting an older one opens it in the legacy read-only viewer, which already renders its stored HTML. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The static rendering (a checkpoint's static.html) carried BlockNote's structural CSS but no colours, so a share or a checkpoint view in dark mode was dark text on white. It now has a small stylesheet that follows the companion's data-theme in Primer and the viewer's colour scheme on a share. Print / PDF is /d/:docId/print: a sandboxed frame on /api/documents/:docId/print, which serves a checkpoint's static.html (or the live state, rendered by the same code) with a print stylesheet and a script that opens the print dialog; print is always light. A test pins that a share link of a live document serves the published checkpoint, not live state. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
BlockNote's paste already takes HTML from Google Docs, Word, Notion and the web. What Primer changes is Markdown: text BlockNote recognises as Markdown goes to POST /api/convert/markdown, the importer's parser, so a paste and an upload of the same text give the same blocks. Front matter stays in the paste as a source block, ids are assigned by the editor on insert, and the cursor block is captured before the request so the result lands where the paste was. The route is documents:write and capped at 1M characters. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Three inline content types in Primer's schema (each its own file in packages/blocks), usable in paragraphs and table cells: @ mentions a person, and the slash menu gains Date and Dropdown. A chip's props are editor-writable, so nothing looks anything up from them: a mention keeps the person's id and the name it was made with, never an email, and serialised pages show only text (no inputs). Text export reads a chip as @name, the date or the chosen value. The convert route also gets a body limit before parsing and a per-user rate limit, so an oversized paste is refused without being buffered. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
chips.tsx was blank in the server's Markdown, HTML and print output when the API ran under tsx (dev), because tsx didn't pick up packages/blocks's react-jsx setting and the server render threw 'React is not defined', which the export swallowed. The pragma makes the JSX runtime explicit in both files that hold JSX. Found in the browser check; vitest uses the automatic runtime so the tests passed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Every user-facing string in apps/web/src moves to en.json and is read through t(key, vars), with no library. de, es, fr, ja and zh are picked from navigator.language (en otherwise), and BlockNote's own dictionary comes from the same resolver. Tests: every locale has every key and placeholder in en.json, the language picks the locale, and a lint test fails on a user-facing literal left in JSX text, readable attributes, feedback properties or prose strings, so a new literal in a later change fails CI until it is added to en.json (and the other locale files). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
maxsam4
force-pushed
the
stack/collab-m2c-tabs
branch
6 times, most recently
from
November 19, 2026 19:36
77a0995 to
099348a
Compare
maxsam4
force-pushed
the
stack/collab-m2c-tabs
branch
2 times, most recently
from
November 19, 2026 20:10
02de106 to
88b29ca
Compare
maxsam4
force-pushed
the
stack/collab-m2c-tabs
branch
2 times, most recently
from
November 19, 2026 20:17
68f1ccb to
1c18da6
Compare
maxsam4
force-pushed
the
stack/collab-m2c-tabs
branch
2 times, most recently
from
November 19, 2026 20:33
b1c373d to
62c1116
Compare
maxsam4
force-pushed
the
stack/collab-m2c-tabs
branch
2 times, most recently
from
November 19, 2026 20:56
8a69213 to
dd12399
Compare
This was referenced Nov 19, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #149 (M2c), which is stacked on #148 (M2b) and #146 (M2a). Review the nine commits from
fix(web): versions from before a document went live…onward; until #149 merges, this PR's diff againstmasterincludes the lower PRs.Summary
M10d of the collaboration plan: the editor surface and chrome.
packages/blocks/src/chips.tsx, one line in the schema).@mentions a person; the slash menu gains Date and Dropdown. They are inline content, so they work in paragraphs and table cells. Props are editor-writable, so nothing is looked up from them: a mention keeps the person's id and the name it was made with (never an email), and serialised pages show text only. Markdown, text and static output read a chip as@name, the date or the chosen value.POST /api/convert/markdown(the importer's parser), so a paste and an upload give the same blocks. Front matter stays as a source block, ids are assigned on insert, the cursor block is captured before the request, and a failed request pastes plain text. The route isdocuments:write, with a body limit before parsing (413) and a per-user rate limit.data-themein Primer, the viewer's colour scheme on a share)./d/:docId/printshows/api/documents/:docId/printin a sandboxed frame: a checkpoint'sstatic.html(?version=n), or the live state rendered by the same code, with a print stylesheet (always light) and a script that opens the print dialog. Printing from the live view prints the live state, not a stale checkpoint. The menu offers Markdown, HTML and Print / PDF. Shares already serve the published checkpoint'sstatic.html; a test pins that.apps/web/srcmoves toi18n/en.json, read throught(key, vars)(no library), withde,es,fr,jaandzhchosen fromnavigator.language; BlockNote's dictionary uses the same resolver. A lint test fails on a UI literal left in JSX text, readable attributes, feedback properties or prose strings, so later PRs that add UI text need keys in every locale file.VersionSummaryDTO.bundledmarks checkpoints; selecting an older version opens it in the legacy version viewer.Notes and deviations
detectMarkdown, which BlockNote does not export. The paste hook wrapseditor.pasteMarkdown, so BlockNote's own detection still decides what is Markdown.window.promptwhen it is inserted.packages/blocks's source block still has two English labels (Preview, Source), outsideapps/web/src.exportHtmlis the renderer they will use.docs/…/authoring.mddoes not exist at this base, so there is no section to add.Test evidence
codegen-drift-check,db:migrate:test,typecheck,-r build,test(api 93 files / 880 tests, web 34 / 349, blocks 2 / 3, mcp 5 / 124),audit --audit-level=high(one low finding).versions from before the document went live are listed as not bundledand a web test that selecting one opens the viewer;share link of a live doc serves the published checkpoint, not live state;print renders the checkpoint or the live state, light and sandboxed;pasted Markdown becomes the same blocks as an upload, front matter and bad bodies, an oversized body refused with 413 before parsing, and the rate limit;editor uses the dark theme when Primer is dark,every locale file has every key in en.json, andno JSX text literal remains outside i18n.pnpm devAPI in mock auth plus Vite):@listed a person and inserted@Mock Reviewer;/dateinserted a date chip;data-color-scheme="dark"with Primer's dark tokens;/d/:docId/printrendered it and produced a PDF;de-DEbrowser showed German chrome and library.tsxthe chips rendered blank in server output (React is not defined, swallowed); fixed with an explicit JSX runtime pragma.🤖 Generated with Claude Code