Repository navigation
Keep checkout paths and operational settings out of the model-call cache fingerprint - #90
Merged
Merged
Conversation
Hash the resolved target, skill registry, and semantic config. Version the run fingerprint so older cache keys miss and age out while the stored response format remains compatible. Remaining #30 work: materialized eval fixture commits can have different Git timestamps, producing different commit SHAs that also appear in the planner prompt. This change makes equal resolved targets replay across fixture directories but does not stabilize those commit inputs or resolve same-path misses.
🧞 Codegenie ReviewWarning Review completed with unresolved questions. 1 question(s) remain unresolved; absence of a confirmed finding does not establish safety. 0 confirmed findings retained from completed work. Unresolved questions require attention. CoverageReviewed 5/5 hunks. 🙋 Needs Human Attention
Stats
No confirmed findingsNo confirmed findings were retained. The limitations above prevent a clean conclusion. |
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83, found in the #44 deep review. Refs #30, which stays open.
The model-call cache's run fingerprint hashed the absolute repository path and all of
config.reviewandconfig.llm, including concurrency and timeouts. The same request from another checkout or worktree, or after a concurrency-only change, could therefore never replay. Plan 35 step 5 intended that reuse.Change
git.baseBranch(already covered by the resolved target), worker and provider concurrency, and wall-clock timeouts.The per-call key still hashes the actual routing, reasoning, prompts and history, tools, schemas and tool budgets.
Remaining #30 work
Materialized eval fixture commits can get different timestamps and SHAs even when their files match, so some eval re-runs will still miss.
Verification
pnpm check,pnpm test(1629 tests) andgit diff --checkpass.git range-diffconfirms the patch is unchanged after it.🤖 Generated with Claude Code