Repository navigation
Fix verifier, composer and reporting bugs from the #44 review - #89
Conversation
The keep criterion requires false-positive risk that is not high, but a keep or revise with falsePositiveRisk "high" and required evidence present was accepted and published. normalizeSubmittedVerdict now turns it into a reject with its own reason and a verification_high_false_positive_risk_normalized_to_reject event. Missing evidence keeps precedence and its existing reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With review.verify=false the verifier synthesized keep verdicts with requiredEvidencePresent true, so the composer's low-confidence exception treated unverified candidates as verified and could publish them inline. The synthetic verdict now reports requiredEvidencePresent false: nothing was checked. human-attention's reason-string test for the same case is now redundant and removed, leaving one rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
revisedFinding rebuilt a revised finding from submitted schema fields and dropped the host-owned provenance, so every verified promoted finding (each one is revised) stopped looking promoted, and the composer's promoted representative branch only ran when verification was off. The revision now forwards the trusted provenance like producedBy and the cluster fields; the verifier still cannot patch it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A revise rebuilt severity from the submitted fields only. When Stage 7 had capped a critical finding to medium, a title-only revise resubmitted medium, applySeverityPolicy did not cap again, and severityBeforeCap was lost, so the never-hide-critical guarantee no longer applied. The revised finding now keeps the original severityBeforeCap when the verifier leaves the capped severity unchanged; a severity the verifier changes replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Stage 10 error that was neither budget exhaustion nor a recoverable LLM error was rethrown before any report existed, and review-runner assigns retainedReview only after the composer returns, so the failure report had zero findings although verification had finished. The spec says Stage 10 invalidity must not drop verified findings. The composer now still builds the deterministic fallback report on that failure path and hands it to the runner (reviewRetainedOnCompositionFailure) before rethrowing. The run still fails, and its failure report carries the verified findings, the fallback composition mode and the partial banner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
refreshReviewHealth re-rendered postingPlan.reviewBody without the composition outcome, so a review that used composer fallback lost its "Report synthesis failed" banner on GitHub while the markdown report kept it. It now passes result.composition like the original render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
validatePlan prefixed "planner_empty_lenses: " to any decision whose lens set came back empty, including a valid skip that runs no lenses. The hunk stayed skipped but lost the diagnostic reason the component spec requires for skips. Skips now keep the planner's reason; non-skip decisions still record the empty-lens default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Configuration skips were disclosed as "<path>: <reason>", but planner skips only raised the generic excluded count, so their path and reason existed only in the coverage artifact. aggregateRunCoverage now discloses both kinds the same way, under the existing ten-entry limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stage timings come from stage_started/stage_completed events, but recordEvent returned before recording anything when telemetry was off, the default, so snapshotStageTimings was empty and the report's stage timings line disappeared. The stage start/complete timestamps are now recorded regardless; nothing else is collected or written when telemetry is off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The deleted-test rule (plan 92 E1) raised a packet to deep after Stage 6 had already chosen its profile, lenses, context and tool budget from the planned coverage. A simple packet kept a 0/0/0 budget and no tools; a standard one got 10/3/20k instead of the investigate 20/6/48k, and the prompt kept the old profile. buildPacket now applies the rule right after computing the test-coverage delta, so the escalated coverage drives context, profile, lenses and tool budget, and the packet carries coverageEscalation and emits coverage_escalated as before. applyCoverageEscalations keeps the E2 telemetry and the run-level summary. The rule moves into the exported coverageEscalationReason, which removes coverage-escalation's import of packet-builder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review finding: compositionFailure doubled as the presence check, so a composer rejecting with undefined was treated as success, and a string or null reason could not key the WeakMap, so the runner lost the retained review. Failure presence is now an explicit flag, and a primitive reason is wrapped in an Error (cause = the original) that carries the handoff. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🧞 Codegenie ReviewWarning Review completed with unresolved questions. 10 question(s) remain unresolved; absence of a confirmed finding does not establish safety. 0 confirmed findings retained from completed work. Unresolved questions require attention. CoverageReviewed 38/39 hunks.
🙋 Needs Human Attention
Additional unresolved notes suppressed: 5. Stats
No confirmed findingsNo confirmed findings were retained. The limitations above prevent a clean conclusion. |
…on (#60) PR #89 review: the deterministic fallback review was registered for the failure path only after the stage-10 artifact writes. A write that rejected in between reached the runner as a different error, and the failure report had zero findings. Any error after the review is built now carries it (reviewRetainedOnCompositionFailure); a write failure is still the error the run reports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR #89 review: the raw skip list was cut to ten before reasons were deduplicated, so ten identical path/reason skips used the whole limit and hid later reasons. Path/reason pairs are now deduplicated first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… inputs (#59) PR #89 review: replaces the dropped already-deep case. A deep test-file packet whose deleted tests leave surviving references gets no coverageEscalation and no coverage_escalated event. The applyCoverageEscalations test now compares against a snapshot taken before the call, so an in-place mutation would fail it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…line # Conflicts: # tests/pipeline-phase5.test.ts
Fixes #59, #60, #61, #62, #63, #64, #65, #71, #72 and #73, found in the #44 deep review. One commit per issue, plus one review-fix commit.
Verifier and publication
review.verify = false, the synthetic keep now recordsrequiredEvidencePresent: false, so unverified candidates no longer qualify for the verified low-confidence exception. Human-attention resolution uses the same field.falsePositiveRisk: highbecomes a reject, as the architecture's keep criteria require. A warning event records it.severityBeforeCap).Composition and reporting
undefined, string ornullreasons. Making such errors stage-local is a separate decision (recommendation 15 of the synthesis).Planning and packets
planner_empty_lenses.Verification
pnpm check,pnpm test(1601 tests) andgit diff --checkpass.747cd06with no findings.🤖 Generated with Claude Code