You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Adjudicated rejects do not emit note-suppression telemetry #79
Problem: A Stage 9 reject suppresses a human-attention note while no final finding suppresses any note. The event human_attention_hints_suppressed_by_adjudicated_reject is not emitted, so telemetry undercounts reject-driven suppression.
File:line: src/pipeline/human-attention.ts:283-302.
Evidence: Two independent batch audits and @lead-dev-2 confirmed the closing brace at :302 encloses the event at :293-301; no test asserts the event.
Suggested fix size: S; move the event emission out of the incorrectly scoped block and add a regression test.
Found during #44 (workstream D; none disputed in the challenge round).
Tracking update: status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped PR covers #79, #80, #81, #82 and #84. Criteria: a regression test that fails without the fix; check and test green; @Reviewer approval. Next step: implement.
Batch 3 review update (supersedes the prior next-step record): status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry at head ab4438e (6 commits); group #79, #80, #81, #82 and #84. Batch was in review; follow-up commit ab4438e has now landed. Criteria: regression test fails without the fix; check and test green; @Reviewer approval. Next step: request @Reviewer re-review of the updated head.
Review update (supersedes the prior approval/next-step record): status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped batch #79, #80, #81, #82 and #84; PR #86#86 is OPEN at exact head 0a0a99b against f240376. Verdict: changes required on @Reviewer fast-lane re-review. CI, CodeQL and Codegenie review checks are green; git diff --check is clean. Earlier P3 non-chunked/zero-chunk lifecycle findings are fixed, and the latest three Codegenie question groups are answered in the operator report. One P3 test gap remains: in the non-recoverable schema-invalid chunk regression, assert Stage 5 emits stage_completed with degraded:true and chunked:true. Next step: add that assertion and request @Reviewer re-review.
Review/fix update (supersedes the prior changes-required next-step record): status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped batch #79, #80, #81, #82 and #84; PR #86#86 now has head 49c5dae against f240376. The prior review at 0a0a99b required one P3 test gap: the non-recoverable schema-invalid chunk regression must assert Stage 5 emits stage_completed with degraded:true and chunked:true. Commit 49c5dae adds that assertion as one test-line commit on 0a0a99b. Local pnpm check passed and pnpm test passed (69 files / 1594 tests); PR CI, CodeQL and Codegenie review checks are rerunning. Reviewer verdict remains changes required pending verification of this fix. Next step: @Reviewer verifies only the 49c5dae diff, per the operator decision, then records the verdict.
Completion record: status completed; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped batch #79, #80, #81, #82 and #84; PR #86#86 was squash-merged at 2026-11-19 22:31:51Z as merge commit 0556928. Verdict: approve. @Reviewer approved exact head 49c5dae after reviewing only 0a0a99b..49c5dae; no verified findings. The P3 test gap is fixed by asserting Stage 5 stage_completed with degraded:true and chunked:true. Checks: diff-check clean; CI, CodeQL and Codegenie review green; developer reported pnpm check and pnpm test (69 files / 1594 tests) passed. Next step: none; integrated and completed.
Activity
pkieltyka commentedon Nov 19, 2026
Tracking update: status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped PR covers #79, #80, #81, #82 and #84. Criteria: a regression test that fails without the fix; check and test green; @Reviewer approval. Next step: implement.
pkieltyka commentedon Nov 19, 2026
Batch 3 review update (supersedes the prior next-step record): status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry at head ab4438e (6 commits); group #79, #80, #81, #82 and #84. Batch was in review; follow-up commit ab4438e has now landed. Criteria: regression test fails without the fix; check and test green; @Reviewer approval. Next step: request @Reviewer re-review of the updated head.
pkieltyka commentedon Nov 19, 2026
Review update (supersedes the prior approval/next-step record): status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped batch #79, #80, #81, #82 and #84; PR #86 #86 is OPEN at exact head 0a0a99b against f240376. Verdict: changes required on @Reviewer fast-lane re-review. CI, CodeQL and Codegenie review checks are green; git diff --check is clean. Earlier P3 non-chunked/zero-chunk lifecycle findings are fixed, and the latest three Codegenie question groups are answered in the operator report. One P3 test gap remains: in the non-recoverable schema-invalid chunk regression, assert Stage 5 emits stage_completed with degraded:true and chunked:true. Next step: add that assertion and request @Reviewer re-review.
pkieltyka commentedon Nov 19, 2026
Review/fix update (supersedes the prior changes-required next-step record): status In progress; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped batch #79, #80, #81, #82 and #84; PR #86 #86 now has head 49c5dae against f240376. The prior review at 0a0a99b required one P3 test gap: the non-recoverable schema-invalid chunk regression must assert Stage 5 emits stage_completed with degraded:true and chunked:true. Commit 49c5dae adds that assertion as one test-line commit on 0a0a99b. Local pnpm check passed and pnpm test passed (69 files / 1594 tests); PR CI, CodeQL and Codegenie review checks are rerunning. Reviewer verdict remains changes required pending verification of this fix. Next step: @Reviewer verifies only the 49c5dae diff, per the operator decision, then records the verdict.
Fix LLM repair, planner degradation and telemetry bugs from the #44 r…
pkieltyka commentedon Nov 19, 2026
Completion record: status completed; owner peter/@lead-dev-2; branch peter/44-fixes-llm-telemetry; grouped batch #79, #80, #81, #82 and #84; PR #86 #86 was squash-merged at 2026-11-19 22:31:51Z as merge commit 0556928. Verdict: approve. @Reviewer approved exact head 49c5dae after reviewing only 0a0a99b..49c5dae; no verified findings. The P3 test gap is fixed by asserting Stage 5 stage_completed with degraded:true and chunked:true. Checks: diff-check clean; CI, CodeQL and Codegenie review green; developer reported pnpm check and pnpm test (69 files / 1594 tests) passed. Next step: none; integrated and completed.