You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(reporter): avoid duplicate FAIL headers on retry (fix #11454)
#11480
When a test fails with retry: 2, printTaskErrors() merges the identical errors but adds the same task to the merged error entry once for each retry. This causes the reporter to print the same FAIL header multiple times, even though the error itself is merged correctly.
This change ensures a task is only added once to each merged error entry.
Added a regression test covering a deterministic failure with retry: 2. The test fails without the fix and passes with it.
AI-assisted - ChatGPT assisted with the investigation and draft. I reviewed and tested the changes.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.
Tests
Run the tests with pnpm test:ci.
Documentation
If you introduce new functionality, document it. You can run documentation with pnpm run docs.
Changesets
Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Description
Resolves #11454
When a test fails with
retry: 2,printTaskErrors()merges the identical errors but adds the same task to the merged error entry once for each retry. This causes the reporter to print the sameFAILheader multiple times, even though the error itself is merged correctly.This change ensures a task is only added once to each merged error entry.
Added a regression test covering a deterministic failure with
retry: 2. The test fails without the fix and passes with it.AI-assisted - ChatGPT assisted with the investigation and draft. I reviewed and tested the changes.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docs.Changesets
feat:,fix:,perf:,docs:, orchore:.Original implementation from #11459 by @arjunharshana
All reactions