Skip to content

Commit cdb688d

Browse files
fix PHP 7 method name lifetime in vkext calls (#1706)
1 parent e6c1a00 commit cdb688d

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎vkext/vk_zend.h‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,18 @@ static zend_always_inline void vk_zend_call_known_instance_method(zval *object,
232232
zend_object* zobj = Z_OBJ_P(object);
233233
zend_string* method_name = zend_string_init(name, name_len, 0);
234234
zend_function* fun = Z_OBJ_HANDLER_P(object, get_method)(&zobj, method_name, 0);
235-
zend_string_release(method_name);
236235
if (!fun) {
236+
zend_string_release(method_name);
237237
return; // retval stays UNDEF
238238
}
239239
#if PHP_MAJOR_VERSION >= 8
240+
zend_string_release(method_name);
240241
zend_call_known_instance_method(fun, zobj, retval_ptr, param_count, params);
241242
#else
242243
zval method_name_zval;
243244
ZVAL_STR(&method_name_zval, method_name);
244245
call_user_function(NULL, object, &method_name_zval, retval_ptr, param_count, params);
246+
zend_string_release(method_name);
245247
#endif
246248
}
247249

0 commit comments

Comments
 (0)