Repository navigation
[Performance] Wide pre-mount 4/5: pre-mount lifecycle - #103975
JakubKorytko wants to merge 5 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
65b7344 to
7a2f719
Compare
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a2f719653
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
No product review required |
Explanation of Change
Part 4/5 of splitting #102324.
Adds the pre-mount lifecycle: building and cancelling the hidden destination inside the tab navigator (wideTabPreMount), tracking it in preMountBuffer, and revealing it from revealRouteBeforeDismissingModal, with the Search write held until the panel is gone. A cancelled pre-mount no longer clears the totals of the visible Search. Browser Back or Forward to an entry saved before the reveal drops the revealed screen from under the report it was mounted under. Nothing builds a pre-mount yet.
Fixed Issues
$ #88596
PROPOSAL: N/A
Tests
Use an account with at least one workspace. If the Category row of the form shows Required, click it and pick any category before submitting.
Test 1 - submit from Home lands on Spend (wide)
+button at the bottom of the left navigation bar, then Create expense, then the Manual tab.1in Amount andTestin Merchant, then click Create expense.Test 2 - submit from Inbox lands on the workspace chat (narrow)
+button in the bottom right corner, then Create expense, then the Manual tab.1in Amount andTestin Merchant, then click Create expense.Test 3 - closing the form without submitting (narrow)
+button in the bottom right corner, then Create expense, then the Manual tab.Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
wide-premount-4-lifecycle-tests.mp4