refactor: resolve attachment keyboard avoidance by platform

Author: nabi-ebrahimi

src/components/PDFView/index.native.tsx

@@ -11,8 +11,8 @@ import useStyleUtils from '@hooks/useStyleUtils';
 import useThemeStyles from '@hooks/useThemeStyles';
 import useWindowDimensions from '@hooks/useWindowDimensions';
 
-import getPlatform from '@libs/getPlatform';
 import {openTravelDotLink} from '@libs/openTravelDotLink';
+import shouldEnableAttachmentModalKeyboardAvoidance from '@libs/shouldEnableAttachmentModalKeyboardAvoidance';
 import {getRelativeUrl, isTravelLink} from '@libs/TravelUtils';
 
 import CONST from '@src/CONST';
@@ -73,7 +73,7 @@ function PDFView({
     const {isKeyboardShown} = useKeyboardState();
     const StyleUtils = useStyleUtils();
     const {insets} = useSafeAreaPaddings();
-    const shouldAvoidPasswordKeyboard = !!isUsedInAttachmentModal && getPlatform() === CONST.PLATFORM.IOS;
+    const shouldAvoidPasswordKeyboard = !!isUsedInAttachmentModal && !shouldEnableAttachmentModalKeyboardAvoidance;
 
     const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);
 

src/libs/shouldEnableAttachmentModalKeyboardAvoidance/index.ios.ts

@@ -0,0 +1,4 @@
+// Avoid the password keyboard inside the PDF form so the attachment pager does not resize.
+const shouldEnableAttachmentModalKeyboardAvoidance = false;
+
+export default shouldEnableAttachmentModalKeyboardAvoidance;

src/libs/shouldEnableAttachmentModalKeyboardAvoidance/index.native.ts

@@ -0,0 +1,4 @@
+// Keep screen-level keyboard avoidance on Android.
+const shouldEnableAttachmentModalKeyboardAvoidance = true;
+
+export default shouldEnableAttachmentModalKeyboardAvoidance;

src/pages/media/AttachmentModalScreen/AttachmentModalContainer/index.native.tsx

@@ -1,17 +1,15 @@
 import ScreenWrapper from '@components/ScreenWrapper';
 
 import attachmentModalHandler from '@libs/AttachmentModalHandler';
-import getPlatform from '@libs/getPlatform';
 import Navigation from '@libs/Navigation/Navigation';
+import shouldEnableAttachmentModalKeyboardAvoidance from '@libs/shouldEnableAttachmentModalKeyboardAvoidance';
 
 import AttachmentModalBaseContent from '@pages/media/AttachmentModalScreen/AttachmentModalBaseContent';
 import AttachmentStateContextProvider from '@pages/media/AttachmentModalScreen/AttachmentModalBaseContent/AttachmentStateContextProvider';
 import type {AttachmentModalOnCloseOptions} from '@pages/media/AttachmentModalScreen/AttachmentModalBaseContent/types';
 import AttachmentModalContext from '@pages/media/AttachmentModalScreen/AttachmentModalContext';
 import type {AttachmentModalScreenType} from '@pages/media/AttachmentModalScreen/types';
 
-import CONST from '@src/CONST';
-
 import {SafeString} from 'expensify-common';
 import React, {memo, useCallback, useContext, useEffect} from 'react';
 
@@ -63,7 +61,7 @@ function AttachmentModalContainer<Screen extends AttachmentModalScreenType>({con
             testID={`attachment-modal-${testID}`}
             enableEdgeToEdgeBottomSafeAreaPadding
             // Keep keyboard avoidance inside the password form so it does not resize the iOS pager.
-            shouldEnableKeyboardAvoidingView={getPlatform() !== CONST.PLATFORM.IOS}
+            shouldEnableKeyboardAvoidingView={shouldEnableAttachmentModalKeyboardAvoidance}
         >
             <AttachmentStateContextProvider>
                 <AttachmentModalBaseContent