Skip to content

ci: call the shared security gates in 0xPolygon/pipelines - #1067

Merged
taylanpince merged 2 commits into
masterfrom
ci/shared-security-gates
Nov 16, 2026
Merged

taylanpince merged 2 commits into
masterfrom
ci/shared-security-gates

Conversation

@taylanpince

Copy link
Copy Markdown
Contributor

Moves this repo's security gates to the shared reusable workflows in 0xPolygon/pipelines (added in 0xPolygon/pipelines#91), pinned to commit cb7db0e on main. The action pins, tool versions and licence allowlist are now maintained there once for every repo; this repo keeps only its own licence exemptions.

What changes

  • dependency-review.yml and zizmor.yml become short callers. The local copies are removed.
  • The licence exemptions (13 packages) carry over unchanged as the allow-dependencies-licenses input. The shared allowlist is the same list this repo already used.
  • Dependabot: the actions group is limited to minor and patch updates, so a major update comes as its own PR.

Behaviour changes

  • zizmor runs on every PR. The .github/** path filter is gone, so it can become a required check without leaving PRs that don't touch workflows waiting on a check that never runs. It still reports to code scanning and doesn't fail the job; blocking on new findings needs a "Require code scanning results" ruleset rule.
  • Dependency review also fails on development dependencies. High-severity advisories in dev and tooling packages now fail it too (fail-on-scopes: runtime, development, unknown), since those run in CI. It still checks only the dependencies a PR adds or changes.
  • Check names gain a prefix, e.g. dependency-review / Dependency review. None of these checks is required on the default branch today, so nothing waits on the old names.

zizmor 1.31.1 and actionlint report nothing on the changed files. Future version bumps arrive as a change of the pinned pipelines commit.

taylanpince and others added 2 commits November 16, 2026 14:59
Dependency review and zizmor now call the reusable workflows in 0xPolygon/pipelines, pinned by
commit, instead of carrying local copies. The action pins, tool versions and
licence allowlist are maintained there; this repo keeps only its own licence
exemptions.

Changes in behaviour:
- zizmor runs on every pull request, without the .github/** path filter, so
  it can become a required check.
- Dependency review also fails on high-severity advisories in development
  dependencies, which run in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Major action updates now come as separate Dependabot PRs, so each gets its
own review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tolgahan-arikan
tolgahan-arikan marked this pull request as ready for review November 16, 2026 15:37
@tolgahan-arikan
tolgahan-arikan requested a review from a team November 16, 2026 15:37
@tolgahan-arikan
tolgahan-arikan requested a review from a team as a code owner November 16, 2026 15:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:38:24.372873Z a8cb799 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tolgahan-arikan tolgahan-arikan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shared workflows at cb7db0e use the same action pins and licence allowlist as the local copies; the 13 exemptions carried over unchanged. zizmor caller now grants contents: read and actions: read, which the shared job requires. All checks pass.

Non-blocking: cb7db0e has no version tag in pipelines (v1–v3 predate these workflows), so Dependabot bumps of this ref will be bare commits and the # main, 2026-11-16 comment will go stale. A tag such as security-gates@1.0.0 would fix both.

@taylanpince
taylanpince merged commit 5d6f3ea into master Nov 16, 2026
11 checks passed
@taylanpince
taylanpince deleted the ci/shared-security-gates branch November 16, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants